[MPlayer-dev-eng] Re: [patch] A-V sync tuneup, round 2

Felix Buenemann atmosfear at users.sourceforge.net
Wed Nov 7 23:22:19 CET 2001


On Wednesday, 7. November 2001 21:17, you wrote:
> > your patch has lines with no if(use_dap_sync) before. for example
> > resetting relative timer. it will break timing code.
>
>  ah, fixed
>
> > i prefer well commented (english! :)) patches.
>
>  I've renamed some variables, I hope it's easier to understand, now ;}
>
> >> note3: RPC timer should be used for timing based on 8khz clock.
> >> note4: RPC is usually disabled for 'average' users. and HZ=100.
> >
> > hm, I didn't think on it, cause I had never enabled it. :} it's a Good
> > Thing, I'll test it tomorrow.. but softsleep even required by
> > non-linux platforms and RPC-less users
>
>  bad news: only the root can use it, users can't, because they can't
> enable interrupts..  it's now implemented, but works only for root

the patch doesn't apply as it's against older or modified mplayer version. 
redo it against fresh cvs.
-- 
Best Regards,
	Atmos

--no sig yet, suffered a system crash :(--



More information about the MPlayer-dev-eng mailing list