[MPlayer-dev-eng] Patch for multi-screen xinerama setup.

[dan carter]

daniel carter wrote:
> 

> The patch add's the new commandline option in cfg-mplayer.h
> It adds to x11_common.h a variable to store the requested screen, and
> two variables to store the upper left xy of the requested screen.  Not
> sure if this is the best place for them.  And i'm a bit confused as to
> why i need to define vo_xineramascreen in both cfg-mplayer.h and
> x11_common.. but it works...
> It changes the screen width and height detection in x11_common.c to
> detect the requested screen.
> It changes the xy hinting in vo_x11.c and vo_xv.c to create the X window
> in the upper left corner of the requested screen.

OK.. Just had a look at a whole bunch of other drivers that use
x11common such as vo_gl.c etc.

Rather than putting 

#ifdef HAVE_XINERAMA
   if(XineramaIsActive(mDisplay))
    {
     hint.x = vo_xinerama_x;
     hint.y = vo_xinerama_y;
    }
   else
#endif
   {
   hint.x = 0;
   hint.y = 0;
   }

into all of these, as i did for x11 and xv, i think it would be better
to define two more general variables vo_screenx and vo_screeny in
video_out.h

all the drivers would then just have the simple code

hint.x = vo_screenx;
hint.y = vo_screeny;

Thoughts?