[MPlayer-cygwin] mencoder very slow on windows

[Gianluigi Tiesi]

On Sat, Dec 08, 2007 at 02:16:10AM +0100, Gianluigi Tiesi wrote:
> On Fri, Dec 07, 2007 at 06:08:35AM -0500, John Brown wrote:
> > 
> > Thomas Plank wrote:
> > >
> > > On my cygwin system it looks like that:
> > >
> > > $ nasm -v
> > > NASM version 2.00 compiled on Nov 30 2007
> > I am using MSYS, not cygwin. I compiled nasm 0.98.39 myself,
> > when it was the most recent version.
> > 
> 
> it's not an mplayer related-issue, it should be fixed in xvid tree,
> perhaps v2.0 is out so it would be nice to make it work
> 
> 0.98 had some little issues, so I've switched to yasm, that is preferred
> over nasm by the configure script
> 
> v2.0 should be ok I think
> but the check in xvid configure it's not usable to compare 2.00
> 
> I'll take a look to make a clean solution
> 
> in the meanwhile use yasm
> 

Attached patch makes a better check for nasm
version, so it works with debian sid version (0.99.06-something)
I've supposed to work with 2.00 so the check passes on this version
perhaps the code is not assemblable using nasm v2
because of errors,
so my patch may be also useless

anyway...

Regards

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/
-------------- next part --------------
--- xvidcore-1.1.3/build/generic/configure.in	2005-11-22 22:01:33.000000000 +0100
+++ xvidcore-1.1.3.sherpya/build/generic/configure.in	2007-12-08 03:35:19.500899400 +0100
@@ -16,7 +16,6 @@
 API_MINOR="1"
 
 dnl NASM version requirement
-minimum_nasm_patch_version=34
 nasm_prog="nasm"
 yasm_prog="yasm"
 
@@ -362,16 +361,17 @@
            dnl
            dnl Checking nasm patch version
            dnl
-           AC_MSG_CHECKING([for nasm patch version])
-           nasm_patch=`$nasm_prog -r | cut -d '.' -f 3 | cut -d ' ' -f 1`
-           if test -z $nasm_patch ; then
-              nasm_patch=-1
-           fi
-           AC_MSG_RESULT([$nasm_patch])
-
-
-           if test "$nasm_patch" -lt "$minimum_nasm_patch_version" ; then
-               AC_MSG_WARN([nasm patch version is too old])
+           AC_MSG_CHECKING([for nasm version])
+           nasm_v=`$nasm_prog -v | cut -d' ' -f 3 | cut -d'-' -f 1`
+           nasm_v1=`echo $nasm_v | cut -d'.' -f 1`
+           nasm_v2=`echo $nasm_v | cut -d'.' -f 2`
+           nasm_v3=`echo $nasm_v | cut -d'.' -f 3`
+           test -z $nasm_v1 && nasm_v1=0
+           test -z $nasm_v2 && nasm_v2=0
+           test -z $nasm_v3 && nasm_v3=0
+           AC_MSG_RESULT([$nasm_v1.$nasm_v2.$nasm_v3])
+           if test "$nasm_v1" -lt "2" -a "$nasm_v2" -lt "99" -a "$nasm_v3" -lt "34"; then
+               AC_MSG_WARN([no suitable nasm version found])
            else
                found_nasm_comp_prog="yes"
 		       chosen_asm_prog="$nasm_prog"