[MPlayer-cygwin] [PATCH] mingw support for TOOLS/netstream
Sascha Sommer
saschasommer at freenet.de
Sat May 7 20:31:32 CEST 2005
Hi,
Am Freitag, den 06.05.2005, 23:11 +0200 schrieb Diego Biurrun:
> On Thu, May 05, 2005 at 08:13:14PM -0400, Erik Lunchpail wrote:
> > > Your patch no longer applies, I reformatted the
> > > Makefile for better
> > > readability and removed $(MPROOT)/libao2/afmt.o.
> > > -lwsock32 should be
> > > part of WIN32_LIB, as I said, so adding it should
> > > not be necessary.
> >
> > Ok, here's another one that applies to current CVS. It
> > compiles in both linux and with mingw without having
> > to edit any files. -lwsock32 does not get added to
> > WIN32_LIB, in fact grep -r wsock32 only returns 2
> > lines in loader/win32.c, so i've left it in.
>
> The Makefile part of this patch looks good and it compiles fine for me
> with your patch applied on Linux.
>
> > I originally hadn't written the patch with the
> > expectation that it would be committed, so i'm not
> > sure what's needed, or if there's any standard i need
> > to follow.
>
> It looks OK now.
>
> Sascha, can you review the rest?
>
Looks fine, commit it.
Sascha
More information about the MPlayer-cygwin
mailing list