[MPlayer-cygwin] reworked vo_winvidix.c

[Sascha Sommer]

Hi,

On Friday 17 June 2005 10:09, Erik Lunchpail wrote:
> I've reworked vo_winvidix.c for personal preference to
> see if i could get it working better with the gui that
> Gianluigi and i work on, so i thought i'd share it
> here.
>
> I haven't made any drastic changes, most notably would
> be moving all of the code from WM_WINDOWPOSECHANGED
> into a new Winvidix_ManageDisplay() function similar
> to that of directx's. I also borrowed some code from
> vo_directx to allow for runtime resize/aspect
> changing. In my SetWindowPos i have a tmpheight + 29
> which i got mostly from trial and error, which seems
> to work (for me at least) but i'm sure there's some
> correct way to calculate that, i just can't figure out
> how.
>
> I also moved the
> mp_input_queue_cmd(mp_input_parse_cmd("quit")) from
> WM_DESTROY and into WM_CLOSE, as that was always
> sending an MP_CMD_QUIT to the gui after finishing a
> file, or pressing stop, and WM_DESTROY now uses
> PostQuitMessage. This should completely unaffect the
> commandline version.
>
> I also made it a lot more readable, which is why i
> didn't send it as a diff.
>

Could you seperate the noncosmetic changes?
The cosmetic changes are unacceptable in their current form.
I won't commit useless changes like
-function(){
+function()
+{

Regards,

Sascha