[MPlayer-cygwin] [PATCH] directx overlay centering when using -wip

Joey Parrish joey at nicewarrior.org
Thu Feb 10 18:24:30 CET 2005


On Thu, Feb 10, 2005 at 04:46:58PM +0100, Sascha Sommer wrote:
> On Wednesday 09 February 2005 17:52, Gianluigi Tiesi wrote:
> > Ok my patch was interfering with -geometry, this is an updated patch
> > that disables autocentering if passing -geometry.
> > This makes mplayer to autocenter ALWAYS the overlay even if window if
> > moved or resized, using -geometry locks overlay size and position.
> 
> I'm not sure but it seems to me like the whole -wid/geometry/keepaspect seem 
> to be stepping on each others toes. If you use -wid together with 
> -nokeepaspect the image fills the whole image, but whenever you use
> -geometry or no keepaspect the overlay does not care about the window and so 
> on. Maybe it is time to add some control calls that can be used via slave 
> mode to set the overlay position and size instead of adding more and more 
> workarounds. What do you think?

I agree completely.

--Joey

-- 
"The Hell Law says that Hell is reserved exclusively for them that believe
in it.  Further, the lowest Rung in Hell is reserved for them that believe
in it on the supposition that they'll go there if they don't."
  HBT; The Gospel According to Fred, 3:1




More information about the MPlayer-cygwin mailing list