[MPlayer-cygwin] questions about ao_dsound

[Florian Dietrich]

Hey!

 --- Sascha Sommer <saschasommer at freenet.de> wrote: 

> > should be sizeof(WAVEFORMATEXTENSIBLE)-sizeof(WAVEFORMATEX).
> 
> I'm not 100% sure. While cbSize should be zero when WAVEFORMATEX is
> used alone [...] says that it should be at least 22 for
> WAVEFORMATEXTENSIBLE.

right, zero when the extensions aren't used. When it's used then 22,
since sizeof(WAVEFORMATEXTENSIBLE) is 40 and sizeof(WAVEFORMATEX) is
18 :-)

> That is an interesting question and there should still be a way to
> swap the channels in an audio filter. However I think it is ok for
> now to reorder them so that it works for ac3. We have to copy the
> data anyway. Hopefully there won't be to much speed difference.

Are the channels always interleaved the way that there's only one
sample for each channel at a time? E.g. 123456123456123456... for
6-Channel Audio? Or are there multiple samples at a time
(111222333444555666111...)?
I'll write some code for it tomorrow if nothing important comes up. I
really want 5.1 sound with mplayer! ;-)

> I think it doesn't matter if  we do dynamic or static linking. The
> current way has the advantage that MPlayer will at least startup on
> systems without directx. I don't even know if there are such
> systems, though.

I don't think there are, but you're right, it's not that important.

> > [buffer size]
>
> If you could improve this that would be great.

Yep, I'll send a patch.

> 
> > * I think there *might* be a bug, which is only masked by the
> > current buffer size and the "Restore" stuff after the lock.
> 
> Share the secret with us ;)

I think I found the problem, but the bug seems to be a different from
what I expected ;-) I'll send a patch for that too (probably
tomorrow).

> I would prefer if you would improve the current code. There really
> shouldn't be to many differences in the implementation. You can
also
> clean up the current code, but be carefull, we won't accept
cosmetic
> changes.

Yep, I know. I'll see what I can do.

Florian


	

	
		
___________________________________________________________
Gesendet von Yahoo! Mail - Jetzt mit 100MB Speicher kostenlos - Hier anmelden: http://mail.yahoo.de