[MPlayer-cvslog] r38140 - trunk/libvo/vo_kva.c

[KO Myung-Hun]

Reimar Döffinger wrote:
> On Fri, May 24, 2019 at 01:42:54PM +0300, komh wrote:
>> -    PCSZ pcszVideoModeStr[3] = {"DIVE", "WarpOverlay!", "SNAP", "VMAN"};
>> +    PCSZ pcszVideoModeStr[] = {"DIVE", "WarpOverlay!", "SNAP", "VMAN"};
> 
> This seems not very robust.
> (for reference, the usage is pcszVideoModeStr[m_int.kvac.ulMode - 1]
> where ulMode seems to be filled in by the API).
> I would suggest to change it to
> PCSZ pcszVideoModeStr[] = {"UNKNOWN", "DIVE", "WarpOverlay!", "SNAP", "VMAN"};
> and
> pcszVideoModeStr[m_int.kvac.ulMode >= sizeof(pcszVideoModeStr)/sizeof(*pcszVideoModeStr) ? 0 : m_int.kvac.ulMode];
> and doing the same for ao_kva.c
> 

Ok, I'll fix them soon.

Thanks.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v6.0.8 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.os2.kr/