[MPlayer-cvslog] r38010 - trunk/configure

[Alexander Strasser]

On 2017-12-23 02:33 +0200, al wrote:
> Author: al
> Date: Sat Dec 23 02:33:10 2017
> New Revision: 38010
> 
> Log:
> configure: x264: Don't do redundant linking checks
> 
> Since linking against libm was changed in SVN r33885 , this loop
> ended up trying the same linking variation in both iterations. This
> is really not a big problem, but it's unneeded and can be confusing.

Seems I accidently cut the last paragraph of the commit message...

I could have removed the for-loop entirely, but that would only save
one line and make the diff harder to read.

Assuming you declare ld_x264 on a line of its own, which would
be favourable.


  Alexander


> Modified:
>    trunk/configure
> 
> Modified: trunk/configure
> ==============================================================================
> --- trunk/configure	Sat Dec 23 01:47:20 2017	(r38009)
> +++ trunk/configure	Sat Dec 23 02:33:10 2017	(r38010)
> @@ -7410,7 +7410,7 @@ if test "$_x264" = auto && test "$_menco
>  int main(void) { x264_encoder_open((void*)0); return 0; }
>  EOF
>    _x264=no
> -  for ld_x264 in "-lx264 $ld_pthread" "-lx264 $ld_pthread" ; do
> +  for ld_x264 in "-lx264 $ld_pthread" ; do
>      cc_check $ld_x264 && libs_mencoder="$libs_mencoder $ld_x264" && _x264=yes && break
>    done
>  fi