[MPlayer-cvslog] r37360 - in trunk: configure gui/win32/skinload.c

[Ingo Brückl]

Reimar Döffinger wrote on Sun, 18 Jan 2015 19:45:21 +0100:

> On Sun, Jan 18, 2015 at 07:22:01PM +0100, Ingo Brückl wrote:
>> >>
>> >>  if wine ; then
>> >> -  extra_cflags="-fno-pic -UWIN32 -U_WIN32 -U__WIN32 -U__WIN32__ -DWINE_NOWINSOCK -Dstricmp=lstrcmpiA $extra_cflags"
>> >> +  extra_cflags="-fno-pic -UWIN32 -U_WIN32 -U__WIN32 -U__WIN32__ -DWINE_NOWINSOCK -Dstrcasecmp=lstrcmpiA $extra_cflags"
>>
>> > Something doesn't add up.
>> > strcasecmp is used all over the place, for example in m_option.c and it
>> > seems to have worked fine for the WINE build without extra defines.
>>
>> It works, but only with a "no prototype" warning. (I gave the explanation in
>> the commit message.)
>>
>> > What is different about the GUI code that makes it not work there?
>>
>> It's not about the GUI but Wine and just about compiling without warnings
>> (and without an #ifdef for Wine).

> And the others all give warnings?

I don't care about warnings in the non-GUI code. Since we don't have a
possibility to compile silently, warnings aren't easily spotted, so I don't
even try in the first place. The GUI code, however, shall compile without
warnings and I'm keeping an eye on that.

> Because I think the missing prototype is an error for all files, not just
> GUI...

Very likely.

> Because to me it looks like the issue really is a missing
> #include <strings.h>
> (note "strings.h", not "string.h")

You're right, string.h is Windows.

Ingo