[MPlayer-cvslog] r37360 - in trunk: configure gui/win32/skinload.c

[Ingo Brückl]

Reimar Döffinger wrote on Sun, 18 Jan 2015 19:05:00 +0100:

> On Fri, Jan 16, 2015 at 10:38:35PM +0100, ib wrote:
>> (We have to define strcasecmp for Wine because there is only a prototype
>> for it with the msvcrt C library, but we are using the native glibc one.)
>>
>> Modified:
>>    trunk/configure
>>    trunk/gui/win32/skinload.c
>>
>> Modified: trunk/configure
>> ========================================================================= =====
>> --- trunk/configure   Fri Jan 16 22:30:02 2015        (r37359)
>> +++ trunk/configure   Fri Jan 16 22:38:35 2015        (r37360)
>> @@ -1821,7 +1821,7 @@ if os2 ; then
>>  fi
>>
>>  if wine ; then
>> -  extra_cflags="-fno-pic -UWIN32 -U_WIN32 -U__WIN32 -U__WIN32__ -DWINE_NOWINSOCK -Dstricmp=lstrcmpiA $extra_cflags"
>> +  extra_cflags="-fno-pic -UWIN32 -U_WIN32 -U__WIN32 -U__WIN32__ -DWINE_NOWINSOCK -Dstrcasecmp=lstrcmpiA $extra_cflags"

> Something doesn't add up.
> strcasecmp is used all over the place, for example in m_option.c and it
> seems to have worked fine for the WINE build without extra defines.

It works, but only with a "no prototype" warning. (I gave the explanation in
the commit message.)

> What is different about the GUI code that makes it not work there?

It's not about the GUI but Wine and just about compiling without warnings
(and without an #ifdef for Wine).

Ingo