[MPlayer-cvslog] r37362 - trunk/libmpdemux/demux_mpg.c

[Alexander Strasser]

On 2015-02-02 22:45 +0100, Reimar Döffinger wrote:
> On Thu, Jan 22, 2015 at 05:24:39AM +0100, Reimar Döffinger wrote:
> > On 22.01.2015, at 03:29, SubJunk <subversion at mplayerhq.hu> wrote:
> > > Author: SubJunk
> > > Date: Thu Jan 22 03:29:44 2015
> > > New Revision: 37362
> > > 
> > > Log:
> > > Fixed support for DVD audio
> > > 
> > > Modified:
> > >   trunk/libmpdemux/demux_mpg.c
> > > 
> > > Modified: trunk/libmpdemux/demux_mpg.c
> > > ==============================================================================
> > > --- trunk/libmpdemux/demux_mpg.c    Sun Jan 18 20:39:27 2015    (r37361)
> > > +++ trunk/libmpdemux/demux_mpg.c    Thu Jan 22 03:29:44 2015    (r37362)
> > > @@ -1107,6 +1107,13 @@ static demuxer_t* demux_mpg_ps_open(demu
> > > {
> > >     sh_video_t *sh_video = demuxer->video->sh;
> > > 
> > > +    if(demuxer->audio->id!=-2) {
> > > +        if(!ds_fill_buffer(demuxer->audio)){
> > > +            mp_msg(MSGT_DEMUXER,MSGL_INFO,"MPEG: " MSGTR_MissingAudioStream);
> > > +            demuxer->audio->sh=NULL;
> > > +        }
> > > +    }
> > 
> > Why?
> > This is simply _wrong_ and I removed it for that reason.
> > The video probe code below will end up throwing away more or less the first second of audio if you do this!
> > Also DVD audio does work just fine, though setting ps_probe is necessary to have it detected reliably with e.g. -frames 0.
> 
> Ping?

  Maybe Klaus is currently not subscribed to -csvlog ?

  Please re-revert this.

> As I know that it breaks some things, I will revert/disable this unless
> I can get a test-case to properly fix it.
> There might be an argument to have ps_probe set to some value > 0 by default.

  @Klaus: 
    For further discussion please also look into ticket #2219:

    https://trac.mplayerhq.hu/ticket/2219


  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20150206/ca3acec2/attachment.asc>