[MPlayer-cvslog] r36944 - in trunk/gui/win32: interface.c playlist.c playlist.h

[Ingo Brückl]

Reimar Döffinger wrote on Tue, 25 Feb 2014 20:43:51 +0100:

> On Tue, Feb 25, 2014 at 07:39:10PM +0100, Ingo Brückl wrote:
>> Reimar Döffinger wrote on Tue, 25 Feb 2014 19:01:27 +0100:
>>
>> >> @@ -501,6 +501,8 @@ static unsigned __stdcall GuiThread(void
>> >>  {
>> >>      MSG msg;
>> >>
>> >> +    (void) param;
>>
>> > This is a bit ugly and might not work in all compilers.
>>
>> I'd say it'll work on most (all?) compilers. Yes, it's ugly.
>>
>> > I think using av_unused on the parameter would be nicer,
>>
>> I don't mind using it, but it would be nice if gcc would warn if such a
>> parameter *will* be used later. (This is the only thing I dislike about the
>> (void) solution. It'll look strange if you forget to remove it later. With
>> av_unused it'll even look stranger.)

> I don't think gcc warns, in part because it is sometimes used for
> variables that will only be used under some #ifdef.
> But I never actually checked...

Do we have a chance to change the definition of av_unused to something like

  #define av_unused(v) __attribute__((unused)) v##_unused

or should we define a mp_unused like this?

This way you would notice if you're going to use the variable (or function)
without removing the av/mp_unused.

Ingo