[MPlayer-cvslog] r36045 - in trunk: command.c configure libaf/af.c libmpcodecs/ve_lavc.c libmpcodecs/ve_x264.c libmpdemux/mf.c

[Reimar Döffinger]

On Sat, Mar 23, 2013 at 02:46:57PM +0200, Ivan Kalvachev wrote:
> On 3/23/13, diego <subversion at mplayerhq.hu> wrote:
> > Author: diego
> > Date: Sat Mar 23 01:50:51 2013
> > New Revision: 36045
> >
> > Log:
> > build: Add _BSD_SOURCE definition for strsep().
> >
> > Modified:
> >    trunk/command.c
> >    trunk/configure
> >    trunk/libaf/af.c
> >    trunk/libmpcodecs/ve_lavc.c
> >    trunk/libmpcodecs/ve_x264.c
> >    trunk/libmpdemux/mf.c
> 
> Why are you putting _BSD_SOURCE in each file and not in CPPFLAGS, like
> you did with the other visibility flags in r36009?

I we'd rather not by accident introduce new functions that require
_BSD_SOURCE
A different question would be why not add it to osdep/strsep.h,
however the answer there is that it won't work unless we include
that file always before the system headers, which is kind of messy.