[MPlayer-cvslog] r35939 - trunk/configure

[Ivan Kalvachev]

On 3/10/13, reimar <subversion at mplayerhq.hu> wrote:
> Author: reimar
> Date: Sun Mar 10 13:30:54 2013
> New Revision: 35939
>
> Log:
> Allow compiling without linking to a system-specific xvmc backend library.
>
> Modified:
>    trunk/configure
>
> Modified: trunk/configure
> ==============================================================================
> --- trunk/configure	Sun Mar 10 13:17:19 2013	(r35938)
> +++ trunk/configure	Sun Mar 10 13:30:54 2013	(r35939)
> @@ -4591,7 +4591,8 @@ EOF
>  fi
>  if test "$_xvmc" = yes ; then
>    def_xvmc='#define CONFIG_XVMC 1'
> -  libs_mplayer="$libs_mplayer -lXvMC -l$_xvmclib"
> +  libs_mplayer="$libs_mplayer -lXvMC"
> +  test -n "$_xvmclib" && libs_mplayer="$libs_mplayer -l$_xvmclib"
>    vomodules="xvmc $vomodules"
>    res_comment="using $_xvmclib"
>  else

I think this is wrong.
libXvMC doesn't implement all essential XvMC api functions, many of
them were left for the specific videocard implementation
library/driver one. (in other words... -lXvMC only, would break the
build).

To use a generic library it was later introduced libXvMCW (W as
wrapper) that can detect the correct videocard implementation and
dynamically link to it.
However in the past it needed /etc/X11/XvMCConfig to contain the
correct library name and it was tricky for the users. This doesn't
seem to be the case anymore. (It works for fglrx out of the box, with
the wrong config file)


I think that the proper solution is to put XvMCW before XvMCNVIDIA or
even always link to it. What do you think?