[MPlayer-cvslog] r36401 - trunk/libmpcodecs/vd.c

[Ingo Brückl]

Reimar Döffinger wrote on Mon, 5 Aug 2013 08:53:42 +0200:

> On Sun, Aug 04, 2013 at 10:19:58PM +0200, ib wrote:
>> Author: ib
>> Date: Sun Aug  4 22:19:58 2013
>> New Revision: 36401
>>
>> Log:
>> Enable switch_ratio -1 with videos with aspect changes.
>>
>> The original aspect ratio may change during playback,
>> so sh->original_aspect must be set accordingly.
>>
>> This is missing in r36391.
>>
>> Modified:
>>    trunk/libmpcodecs/vd.c
>>
>> Modified: trunk/libmpcodecs/vd.c
>> =========================================================================
>> --- trunk/libmpcodecs/vd.c    Sun Aug  4 20:12:24 2013        (r36400)
>> +++ trunk/libmpcodecs/vd.c    Sun Aug  4 22:19:58 2013        (r36401)
>> @@ -158,6 +158,7 @@ int mpcodecs_config_vo(sh_video_t *sh, i
>>      vf_instance_t *vf = sh->vfilter, *sc = NULL;
>>      int palette = 0;
>>      int vocfg_flags = 0;
>> +    static float last_movie_aspect;

> I don't have time to think about it right now, but could you please
> think of another solution?

We could save it in sh (see attached patch), but I doubt it really should be
there.

> The vd part is one of the few that properly supports multiple
> independent instances and I'd like to keep the code like that.
> A static variable means the whole code will break once someone tries
> to open a second decoder.

I didn't know that.

Actually, the whole original_aspect stuff should be realized differently.
I'll prepare a patch to see if it works like I think it should be...

Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: last_movie_aspect.patch
Type: text/x-diff
Size: 1918 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20130805/4ae3eca0/attachment.bin>