[MPlayer-cvslog] r35164 - trunk/libvo/vo_corevideo.m

reimar subversion at mplayerhq.hu
Tue Sep 11 22:03:52 CEST 2012


Author: reimar
Date: Tue Sep 11 22:03:52 2012
New Revision: 35164

Log:
Change geometry for corevideo vo to not take dock into account.

It makes the % placements behave non-intuitively, particularly
with an auto-hide dock where it would depend on whether the
dock is visible right when MPlayer starts up.

Modified:
   trunk/libvo/vo_corevideo.m

Modified: trunk/libvo/vo_corevideo.m
==============================================================================
--- trunk/libvo/vo_corevideo.m	Tue Sep 11 21:39:10 2012	(r35163)
+++ trunk/libvo/vo_corevideo.m	Tue Sep 11 22:03:52 2012	(r35164)
@@ -531,10 +531,13 @@ static int control(uint32_t request, voi
 	//config window
 	[window setContentSize:NSMakeSize(vo_dwidth, vo_dheight)];
 
-	// Use visibleFrame to position the window taking the menu bar and dock into account.
+	// Do not use visibleFrame - taking the menu bar and dock into account
+	// would be nicer in principle, but currently only results in the window
+	// being placed strangely off-center since vo_dx/vo_dy calculation is
+	// not aware of it.
 	// Also flip vo_dy since the screen origin is in the bottom left on OSX.
 	update_screen_info();
-	visibleFrame = [screen_handle visibleFrame];
+	visibleFrame = [screen_handle frame];
 	[window setFrameTopLeftPoint:NSMakePoint(
 		visibleFrame.origin.x + vo_dx,
 		visibleFrame.origin.y + visibleFrame.size.height - vo_dy)];


More information about the MPlayer-cvslog mailing list