[MPlayer-cvslog] r35223 - trunk/libmpcodecs/vd_ffmpeg.c

[Ingo Brückl]

compn wrote on Mon, 1 Oct 2012 18:02:20 -0400:

>>> Modified:
>>>    trunk/libmpcodecs/vd_ffmpeg.c
>>
>>This seemed to have fixed it. Thanks.

> all this because of one little NULL :)

Those were my thoughts, too.

> ingo: are you going to switch to using/testing -vf lavfi now?

I had no such plans (and didn't know about the option which is disabled
by default).

> since the filters are being maintained in ffmpeg now...

I didn't know that, but will check the unsharp filter for sure since it
consumes a lot of my precious CPU time.

> maybe even switch the gui over to using those filters by default.

As long as lavfi is disabled by default, this doesn't seem to be a good
idea. Besides, I have no idea what advantages / disadvantages might be.

Ingo

PS: Trying to recompile mplayer with --enable-vf-lavfi ended with an error.
-------------- next part --------------
CC      libmpcodecs/vf_lavfi.c
libmpcodecs/vf_lavfi.c: In function 'mpsink_query_formats':
libmpcodecs/vf_lavfi.c:101: warning: implicit declaration of function 'avfilter_all_formats'
libmpcodecs/vf_lavfi.c:101: warning: assignment makes pointer from integer without a cast
libmpcodecs/vf_lavfi.c:102: error: dereferencing pointer to incomplete type
libmpcodecs/vf_lavfi.c:105: error: dereferencing pointer to incomplete type
libmpcodecs/vf_lavfi.c:106: error: dereferencing pointer to incomplete type
libmpcodecs/vf_lavfi.c:108: error: dereferencing pointer to incomplete type
libmpcodecs/vf_lavfi.c:111: warning: implicit declaration of function 'avfilter_set_common_pixel_formats'
libmpcodecs/vf_lavfi.c:111: warning: implicit declaration of function 'avfilter_make_format_list'
libmpcodecs/vf_lavfi.c: At top level:
libmpcodecs/vf_lavfi.c:162: warning: initialization from incompatible pointer type
libmpcodecs/vf_lavfi.c:167: warning: initialization from incompatible pointer type
libmpcodecs/vf_lavfi.c: In function 'mpsrc_request_frame':
libmpcodecs/vf_lavfi.c:212: warning: implicit declaration of function 'avfilter_start_frame'
libmpcodecs/vf_lavfi.c:213: warning: implicit declaration of function 'avfilter_draw_slice'
libmpcodecs/vf_lavfi.c:214: warning: implicit declaration of function 'avfilter_end_frame'
libmpcodecs/vf_lavfi.c: At top level:
libmpcodecs/vf_lavfi.c:232: warning: initialization from incompatible pointer type
libmpcodecs/vf_lavfi.c: In function 'get_image':
libmpcodecs/vf_lavfi.c:294: warning: implicit declaration of function 'avfilter_get_video_buffer'
libmpcodecs/vf_lavfi.c:295: warning: assignment makes pointer from integer without a cast
libmpcodecs/vf_lavfi.c: In function 'put_image':
libmpcodecs/vf_lavfi.c:324: warning: implicit declaration of function 'avfilter_poll_frame'
libmpcodecs/vf_lavfi.c:325: warning: implicit declaration of function 'avfilter_request_frame'
make: *** [libmpcodecs/vf_lavfi.o] Error 1