[MPlayer-cvslog] r35472 - trunk/gui/util/list.c

[Ingo Brückl]

Alexander Strasser wrote on Sun, 25 Nov 2012 15:48:01 +0100:

> I would advise to do the renaming in a separate commit. It makes reading
> the diffs unnecessarily harder.

You're right.

> Would make sense to add a "*what != 0" in the middle.

Right again. I had that in mind but somehow forgot to add it. Thanks for
spotting it.

> Closing comment: Maybe not switching to doing the pointer comparison and
> factorizing the strlen calls would result in more straight forward code.
> I think the new code is harder to read because of the asymmetric string
> duplication.

IMO it's more elegant. The asymmetric string duplication is a bit unpleasant,
but I perceived the calculating of string lengths to retrieve a pointer
position as somehow clumsy. (No offence to who has wrote it.)

Ingo