[MPlayer-cvslog] MPlayer-cvslog Digest, Vol 101, Issue 9

[Klaus Burton]

> ------------------------------
>
> Message: 6
> Date: Tue, 6 Nov 2012 21:11:23 +0100
> From: Reimar D?ffinger <Reimar.Doeffinger at gmx.de>
> To: MPlayer CVS changelogs and discussion
> 	<mplayer-cvslog at mplayerhq.hu>
> Subject: Re: [MPlayer-cvslog] r35356 - in trunk/libass: ass.c ass.h
> 	ass_drawing.c ass_parse.c ass_parse.h ass_render.c ass_render.h
> 	ass_render_api.c ass_shaper.c ass_utils.c ass_utils.h
> Message-ID: <20121106201123.GA30969 at 1und1.de>
> Content-Type: text/plain; charset=iso-8859-1
>
> On Tue, Nov 06, 2012 at 06:41:14AM +0100, SubJunk wrote:
>> @@ -639,27 +664,15 @@ void ass_shaper_shape(ASS_Shaper *shaper
>>  #ifdef CONFIG_HARFBUZZ
>>      switch (shaper->shaping_level) {
>>      case ASS_SHAPING_SIMPLE:
>> -        shape_fribidi(shaper, glyphs, text_info->length);
>> +        ass_shaper_skip_characters(text_info);
>>          break;
>>      case ASS_SHAPING_COMPLEX:
>>          shape_harfbuzz(shaper, glyphs, text_info->length);
>>          break;
>>      }
>>  #else
>> -        shape_fribidi(shaper, glyphs, text_info->length);
>> +        ass_shaper_skip_characters(text_info);
>>  #endif
> I think you broke something here, now shape_fribidi is not used at all.
> As a result I guess that right-to-left languages no longer work at all
> with MPlayer.

You're right, fixed in r35368