[MPlayer-cvslog] r34551 - trunk/gui/wm/ws.c

[Alexander Strasser]

Hi

Reimar Döffinger wrote:
> On Thu, Jan 12, 2012 at 07:43:04PM +0100, Diego Biurrun wrote:
> > On Thu, Jan 12, 2012 at 07:08:38PM +0100, Ingo Brückl wrote:
> > > Diego Biurrun wrote on Thu, 12 Jan 2012 18:53:36 +0100:
> > > 
> > > > Can we please at least have cosmetic commits batched into one?
> > > 
> > > If I know before, yes sure, but these were at different stages of my
> > > flow of work.
> > 
> > Then batch stuff together with git.  You still use plain Subversion?
> > 
> > Or batch it all together in large chunks.  Nobody stops you from doing
> > similar cosmetic changes from other gui files at the same time.

  I am not against committing batched cosmetics. Also even without git
those changes can be mostly easily accumulated in a patch file and applied
and committed at a point the author thinks it is worth it.

> I simply can't see that avoiding that bit of clutter (maybe 1 commit in
> 50?) would be worth making an effort.
> Also at least the svn blame history is not cluttered in any way by empty
> line removal commits.

  I agree to Reimar's statement and don't see a problem in those small
cosmetic commits as long as they are clearly flagged in the commit
message.

  Alexander