[MPlayer-cvslog] r34538 - trunk/gui/win32/skinload.c

[Ingo Brückl]

Reimar Döffinger wrote on Tue, 10 Jan 2012 20:33:49 +0100:

> On Tue, Jan 10, 2012 at 12:51:31PM +0100, ib wrote:
>> Author: ib
>> Date: Tue Jan 10 12:51:30 2012
>> New Revision: 34538
>>
>> Log:
>> Remove all #ifdef MP_DEBUG from Win32 GUI code.
>>
>> Change mp_msg() level to MSGL_DBG2 instead.

> I guess it doesn't really matter considering the overall size,
> but keep in mind that this kind of change means all those strings
> end up in the binary, increasing its size.

Yes, I know.

As I stated in my posting "mp_msg vs. mp_dbg" I see a bigger advantage in
tracking down problems with any non-debug binary than in saving some space,
and...someone asked me whether he "could convince me to work on removing
those ifdefs (both CDDA, VCD and probably more)", because "they save maybe
1kB out of 12 MB (as in, 0.01%) from the compiled binary". ;-)

BTW, I've finished a patch which will remove a lot of #ifdefs from the GUI
code that save space, but aren't necessary for compiling or correct
execution, increasing the binary by almost 12 kB, but making the code more
readable.

Ingo