[MPlayer-cvslog] r34132 - trunk/configure

[Reimar Döffinger]

On Sun, Jan 08, 2012 at 01:56:50PM +0100, Reinhard Tartler wrote:
> On So, Sep 25, 2011 at 15:28:25 (CEST), reimar wrote:
> 
> > Author: reimar
> > Date: Sun Sep 25 15:28:25 2011
> > New Revision: 34132
> >
> > Log:
> > Set up HAVE_VFP_ARGS and CONFIG_THUMB correctly to fix compilation for ARM.
> >
> > Modified:
> >    trunk/configure
> >
> > Modified: trunk/configure
> > ==============================================================================
> 
> [...]
> 
> > @@ -2872,6 +2895,19 @@ if arm ; then
> >    fi
> >    echores "$neon"
> >  
> > +  echocheck "ARM THUMB"
> > +  if test $armthumb = "auto" ; then
> > +    armthumb=no
> > +  fi
> > +  if test $armthumb = "yes" ; then
> > +    extra_cflags="$extra_cflags -mthumb"
> > +    def_armthumb='#define CONFIG_THUMB 1'
> > +  else
> > +    extra_cflags="$extra_cflags -marm"
> > +    def_armthumb='#define CONFIG_THUMB 0'
> > +  fi
> 
> I think -marm is wrong:
> 
> https://buildd.debian.org/status/fetch.php?pkg=mplayer&arch=armel&ver=2%3A1.0~rc4.dfsg1%2Bsvn34492-1&stamp=1325969800
> 
> The build fails because the libmpeg2 uses armv5 speicific
> instruction. I'm thinking about changing the extra_cflags to read like
> this:
> 
> extra_cflags="$extra_cflags -marmv5"
> 
> Reimar, how do you think about this?

-marm is the opposite of -mthumb, it has nothing at all to do with which
version as far as I can tell.