[MPlayer-cvslog] r35665 - trunk/gui/ui/actions.c

Alexander Strasser eclipse7 at gmx.net
Tue Dec 11 20:57:28 CET 2012


Hi Ingo,

ib wrote:
> Author: ib
> Date: Tue Dec 11 14:48:19 2012
> New Revision: 35665
> 
> Log:
> Reset media information while changing tracks in stop mode.
> 
[...]
> @@ -358,8 +358,8 @@ void uiCurr(void)
>   */
>  void uiPrev(void)
>  {
> -    int stop = False;
> -    plItem *prev;
> +    int stop = False, unset = True;
> +    plItem *prev = NULL;
>  
>      if (guiInfo.Playing == GUI_PAUSE)
>          return;
> @@ -392,7 +392,8 @@ void uiPrev(void)
>                  guiInfo.Track = 1;
>                  stop = True;
>              }
> -        }
> +        } else
> +            unset = False;

  It is not important, but here and below you could have used
a positive name for the boolean variable. Like is_set or similar.
It usually makes reading/following the code easier.

  Otherwise I didn't read to closely.

  [...]

  Alexander


More information about the MPlayer-cvslog mailing list