[MPlayer-cvslog] r34871 - trunk/stream/stream.c

[Reimar Döffinger]

On Sun, Apr 22, 2012 at 10:46:25AM -0400, compn wrote:
> On Sun, 22 Apr 2012 14:10:49 +0200 (CEST), reimar wrote:
> >
> >With this change, no server/network outage of any kind shorter
> >than 5 seconds should cause MPlayer to give up anymore.
> 
> want to you make it a runtime option?
> lots of strange users like fiddling with wifi networks and broken
> internet. maybe they want 120+ second timeouts like some protocols
> handle.

There is already the normal network timeout.
This is rather the case where the network timeout has already happened
and we're trying again.
Considering how rarely this issue seems to appear, I don't really like
adding more option clutter for it.
Not until someone comes with some real need for it. And even then
we probably should add options for the ordinary network timeout first.
My concern with the original code was mostly that e.g. a 1 ms
misconfiguration in a local firewall (where it would immediately close
any connection) could cause MPlayer to stop playing.
I think there are still some issues, e.g. I believe the seeking code
does not retry, so doing a seek right when there is a (even very short)
network failure will break things, but that's for some other time.