[MPlayer-cvslog] r34143 - in trunk: Makefile configure

[Diego Biurrun]

On Sat, Oct 22, 2011 at 04:27:32PM +0200, Reimar Döffinger wrote:
> On Sat, Oct 22, 2011 at 04:16:03PM +0200, Diego Biurrun wrote:
> > On Fri, Oct 07, 2011 at 11:25:15AM +0200, Diego Biurrun wrote:
> > > On Sat, Oct 01, 2011 at 12:05:54AM +0200, Reimar Döffinger wrote:
> > > > On Wed, Sep 28, 2011 at 11:59:02AM +0200, diego wrote:
> > > > > +OS_FEATURE-$(GLOB)                   += osdep/glob-win.c
> > > > 
> > > > >  echocheck "glob()"
> > > > > -_glob=no
> > > > > -statement_check glob.h 'glob("filename", 0, 0, 0)' && _glob=yes
> > > > > -need_glob=no
> > > > > -if test "$_glob" = yes ; then
> > > > > -  def_glob='#define HAVE_GLOB 1'
> > > > > -else
> > > > > -  def_glob='#undef HAVE_GLOB'
> > > > > -  # HACK! need_glob currently enables compilation of a
> > > > > -  # win32-specific glob()-replacement.
> > > > > -  # Other OS neither need it nor can they use it (mf:// is disabled for them).
> > > > 
> > > > Did you read that? Because I can't see how trying to compile glob-win.c
> > > > would work on non-Windows systems, no matter how much they lack glob()
> > > 
> > > You are right of course.
> > > 
> > > I suspect that modern versions of Cygwin and MinGW support glob() and
> > > we can drop this replacement entirely.  Can anybody test my hypothesis?
> > 
> > I have Cygwin and MinGW in a virtual machine now.  Cygwin does support
> > it, MinGW does not.
> > 
> > I don't think the clutter supporting mf:// on fringe OSes is worth the
> > clutter it adds.  So I would suggest conditionally compiling libmpdemux/mf.c
> > and dropping osdep/glob-win.c plus the ifdeffery in mf.c.
> 
> I can't parse this.

That sentence got mangled indeed.

> dropping glob-win is not ok IMO (unless you mean integrating it into
> mf.c, but even that is a bit questionable).
> And mf:// is already not supported on fringe OS, it only works on
> systems with glob and Windows.

I meant to suggest dropping the windows-only glob() replacement, but I
have no strong feelings about this.  I'll restore it tomorrow.

Diego