[MPlayer-cvslog] r34228 - trunk/stream/stream.h

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Oct 21 13:36:33 CEST 2011


On Fri, Oct 21, 2011 at 06:56:43AM -0400, compn wrote:
> On Fri, 21 Oct 2011 11:20:07 +0200, Diego Biurrun wrote:
> >On Fri, Oct 21, 2011 at 10:49:48AM +0200, cehoyos wrote:
> >> 
> >> Log:
> >> Fix compilation: Partly revert r34227.
> >
> >Did writing sensible log messages go completely out of style now?

Including the actual error or warning for error or warning fixes is
certainly recommended.

> how much cola are you up to this year? trying to break the record? :D

It did seem like a bad streak :-)
Code cleanup done in a haste has that nasty habit of coming to bite you.
Always feel free to send a patch first if time is tight, it
probably won't help since nobody will review properly, but at least
you get to share cola with everyone else for not doing a proper review
;-)
(not that it's a big deal either way)


More information about the MPlayer-cvslog mailing list