[MPlayer-cvslog] r34211 - trunk/gui/win32/interface.c

[Ingo Brückl]

Reimar Döffinger wrote on Wed, 19 Oct 2011 19:22:59 +0200:

> I would prefer to get rid of it, but I don't think that is a good idea
> as far as I understood your comments.

We really need it.

>>> (It also raises the question whether it wouldn't be simpler and
>>> more reliable to have this in the GUI code,
>>
>> By "GUI code" you mean...? The X11/GTK GUI? It's in the Win32 GUI code
>> where it belongs IMO.

> Yes, win32 of course.

There it is.

>> The Wine port would consider this an absolute path, doesn't find it in the
>> C: drive mapping and refuses it. (Due to the backslash there is no way to
>> access it.)

> Do you mean with or also without the translation code we were discussing?

It doesn't come to the translation code. The refusion takes place in
guiPlaylistInitialize(), so it doesn't make it into the playlist.
(Independent from the translation code.)

> Btw. I just realised that the code probably can't figure out quite a few
> more cases like file://c:.., ffmpeg://file://, ffmpeg://cache://c: etc
> :-)

These :// do not get translated by GetFullPathName(), so if they are
accessible by Linux they will also be so by the Wine port.

>>> A secondary question is why MPlayer compiled for Wine will not use Wine's
>>> implementation of open() which would handle this correctly.
>>
>> This is a good question. Maybe a native glibc C library vs. the msvcrt C
>> library issue. Wine produces ELF objects rather than PE32 executables and
>> we unset all WIN32 defines, so it's closer to Linux (which is the advantage
>> of this port, because all Linux stuff can be used).

> The more interesting question is whether we could do something about it.
> I mean since the purpose is to test the Windows code, it would be better
> if we were closer to Windows behaviour - of course without losing the
> ability to use installed zlib etc. from Linux.

As soon as I learn something related to this problem I'll improve the Wine
port and try to get rid of everything that isn't needed, but at the moment
I'm not in the mood of further investigations and would like to focus on
other matters - the GUI and my pending patches.

Reimar Döffinger wrote on Wed, 19 Oct 2011 19:25:12 +0200:

>> <win32.interface.patch>

> Seems good to me. I have the feeling the grammar is a bit strange though -
> but doesn't really matter.

I'll sleep over it and try to revise for better grammar tomorrow.

Ingo