[MPlayer-cvslog] r33439 - trunk/etc/codecs.conf
Reimar.Doeffinger at gmx.de
Sun May 8 12:53:58 CEST 2011
On Sun, May 08, 2011 at 01:45:03PM +0300, Ivan Kalvachev wrote:
> On 5/8/11, reimar <subversion at mplayerhq.hu> wrote:
> > Author: reimar
> > Date: Sun May 8 10:51:44 2011
> > New Revision: 33439
> > Log:
> > Mark mp3lib decoder as buggy, it does not produce proper output
> > when compiled with gcc 4.6
> > Modified:
> > trunk/etc/codecs.conf
> > Modified: trunk/etc/codecs.conf
> > ==============================================================================
> > --- trunk/etc/codecs.conf Sun May 8 10:42:27 2011 (r33438)
> > +++ trunk/etc/codecs.conf Sun May 8 10:51:44 2011 (r33439)
> > @@ -4415,8 +4415,8 @@ audiocodec mp3
> > ; floating point and there are even broken mkv files where the audio
> > ; needs to be parsed, making this codec work more reliably
> > info "mp3lib MPEG layer-2, layer-3"
> > - status working
> > - comment "Optimized to MMX/SSE/3Dnow!"
> > + status buggy
> > + comment "Barely maintained, miscompiles with newer gcc versions"
> > format 0x50 ; layer-1 && layer-2
> > format 0x55 ; layer-3
> > format 0x5500736d ; "ms\0\x55" older mp3 fcc (MOV files)
> I'm quite surprised to see that the fix haven't been committed yet.
You can commit it :-)
However it is not a "fix", the code is still wrong it is just that
for now the compiler is too stupid.
Most likely it will be broken again with gcc 4.7 and I just don't
consider it justified anymore to call our internal mp3lib code
More information about the MPlayer-cvslog