[MPlayer-cvslog] r33422 - trunk/libmpdemux/demux_asf.c

[Reimar Döffinger]

On Sat, May 07, 2011 at 10:23:56PM +0200, Clément Bœsch wrote:
> On Sat, May 07, 2011 at 10:19:26PM +0200, reimar wrote:
> > Author: reimar
> > Date: Sat May  7 22:19:26 2011
> > New Revision: 33422
> > 
> > Log:
> > Remove unused variable.
> > 
> > Modified:
> >    trunk/libmpdemux/demux_asf.c
> > 
> > Modified: trunk/libmpdemux/demux_asf.c
> > ==============================================================================
> > --- trunk/libmpdemux/demux_asf.c	Sat May  7 22:16:05 2011	(r33421)
> > +++ trunk/libmpdemux/demux_asf.c	Sat May  7 22:19:26 2011	(r33422)
> > @@ -363,7 +363,6 @@ static int demux_asf_fill_buffer(demuxer
> >              unsigned char segtype=p[1];
> >              unsigned padding;
> >              unsigned plen;
> > -	    unsigned sequence;
> >              unsigned long time=0;
> >              unsigned short duration=0;
> >  
> > @@ -398,7 +397,7 @@ static int demux_asf_fill_buffer(demuxer
> >  
> >              // Read sequence:
> >  	    if(!check_varlen(p, p_end, flags>> 1)) return 0; // Not enough data
> > -	    sequence = read_varlen(&p, flags >> 1, 0);
> > +	    read_varlen(&p, flags >> 1, 0);
> >  
> >              // Read padding size (padding):
> >  	    if(!check_varlen(p, p_end, flags>> 3)) return 0; // Not enough data
> 
> While this variable give some meaning to the read sequence and can be used
> for debug, what about using the av_unused attribute from FFmpeg/Libav?

Maybe at some point, but in this case it just seemed completely
pointless. There's a comment giving as much information,
the variable name is not useful and our native demuxer should
in the long term be replace by the FFmpeg one anyway (there
are issue with mms streaming etc. that prevent it currently).