[MPlayer-cvslog] r33352 - in trunk/gui: cfg.c cfg.h interface.c

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat May 7 09:23:47 CEST 2011


On Fri, May 06, 2011 at 09:31:26AM +0200, Ingo Brückl wrote:
> I wrote on Wed, 04 May 2011 02:13:29 +0200:
> 
> > I can offer an alternative solution that avoids all this clutter with a few
> > core code changes inside *existing* CONFIG_GUIs.
> 
> > The advantage: Clear and simple. The GUI can react now on *all* MPlayer's
> > exits at each point in time. No issues in any corner case. guiDone() is
> > sufficient, the obscure guiExit() stuff unneeded.
> 
> Reimar, I need your decision whether I shall go on with the cluttering r33352
> approach or with the suggested alternative which I regard as the far cleaner
> and preferrable solution.

I can't say anything since the first patch isn't complete.
E.g. why does guiDone even need to know how far initialization
got, it should be able to figure it out itself.


More information about the MPlayer-cvslog mailing list