[MPlayer-cvslog] r33357 - trunk/gui/app.c

[Reimar Döffinger]

On Wed, May 04, 2011 at 11:07:08AM +0200, Diego Biurrun wrote:
> On Tue, May 03, 2011 at 07:13:25PM +0200, Clément Bœsch wrote:
> > On Tue, May 03, 2011 at 05:55:21PM +0200, ib wrote:
> > > 
> > > --- trunk/gui/app.c	Tue May  3 16:34:40 2011	(r33356)
> > > +++ trunk/gui/app.c	Tue May  3 17:55:20 2011	(r33357)
> > > @@ -24,13 +24,9 @@
> > >  
> > >  guiItems appMPlayer = {
> > > -    { 0 }, { 0 }, 0,
> > > -    { 0 }, { 0 },
> > > -    { 0 }, { 0 }, 0,
> > > -    { 0 }, { 0 }, { 0 }, 0,
> > > -    -1,    { 0 },
> > > -    -1,    { 0 },
> > > -    -1,    { 0 }
> > > +    .IndexOfMainItems = -1,
> > > +    .IndexOfBarItems  = -1,
> > > +    .IndexOfMenuItems = -1
> > >  };
> > 
> > Not that important, but you should put a comma at the end of the last item
> > too. By doing that, if you add an option, you won't have a diff line on
> > the last item (and you'll see only the functionnal change).
> 
> Out of curiosity: Isn't that a C99ism?

Yes. Though one that has existed as extensions since a long time before
and FFmpeg already uses since a very long time.
And one of the things that can make you hate C++ because it still does
not have it.