[MPlayer-cvslog] r33007 - in trunk/gui: app.h mplayer/gui_common.c

Reimar Döffinger Reimar.Doeffinger at gmx.de
Thu Mar 3 21:44:20 CET 2011


On Thu, Mar 03, 2011 at 12:06:42PM +0100, ib wrote:
>  // Button states
>  
> -#define btnPressed  0
> +#define btnDisabled 0
>  #define btnReleased 1
> -#define btnDisabled 2
> +#define btnPressed  2

Maybe switch to using an enum?

> +   ofs = (item->pressed == btnPressed ? 0 : (item->pressed == btnReleased ? 1 : 2));

Maybe a switch/case or a lookup array would be more readable?
Probably not though, it just seems rather ugly.


More information about the MPlayer-cvslog mailing list