[MPlayer-cvslog] r33777 - in trunk/gui: interface.c ui/gtk/equalizer.c

Diego Biurrun diego at biurrun.de
Wed Jun 29 20:35:20 CEST 2011


On Wed, Jun 29, 2011 at 01:35:58PM +0200, ib wrote:
> 
> Log:
> Replace numeric constants for gtkEquChannels array size.
> 
> Use macro FF_ARRAY_ELEMS() instead.

BTW, I'd appreciate git-style "gui:" prefixes for your GUI commits.

> --- trunk/gui/ui/gtk/equalizer.c	Wed Jun 29 13:21:09 2011	(r33776)
> +++ trunk/gui/ui/gtk/equalizer.c	Wed Jun 29 13:35:58 2011	(r33777)
> @@ -255,8 +256,8 @@ static void eqSelectChannelsListRow( Gtk
>   if ( Channel == -1 )
>    {
>     int i,j; equalizer_t eq;
> -   for ( i=1;i<6;i++ )
> -    for ( j=0;j<10;j++ )
> +   for ( i=1;i<FF_ARRAY_ELEMS(gtkEquChannels);i++ )
> +    for ( j=0;j<FF_ARRAY_ELEMS(*gtkEquChannels);j++ )
>       { eq.band=j; eq.channel=i; eq.gain=gtkEquChannels[0][j]; gtkSet( gtkSetEqualizer,0,&eq ); }
>    }
>  }

Didn't you run all of the GUI through uncrustify already?

Diego


More information about the MPlayer-cvslog mailing list