[MPlayer-cvslog] r33629 - in trunk/gui: interface.c wm/ws.c wm/ws.h

[Diego Biurrun]

On Thu, Jun 16, 2011 at 03:09:52PM +0200, ib wrote:
> 
> Log:
> Avoid compiler warnings.

gui: Avoid compiler warnings.

> Remove unused parameter, use passed parameter instead of global variable
> or tag variable as unused to avoid warnings of unused variables.
> 
> --- trunk/gui/wm/ws.c	Thu Jun 16 14:44:28 2011	(r33628)
> +++ trunk/gui/wm/ws.c	Thu Jun 16 15:09:52 2011	(r33629)
> @@ -987,6 +987,8 @@ void wsConvert(wsTWindow *win, unsigned 
>      int dst_stride[4];
>      int i;
>  
> +    (void)Size;

Why not drop the parameter instead?

Unused parameter warnings only appear with -Wextra and then MPlayer
prints about a trillion of them.  Unless we remove all I see little
point in cleaning up just a single instance with this cast hack.

Note that gcc has an attribute for hiding this warning.  Since I believe
the warning is gcc-specific in the first place, we might as well use
that instead.

Diego