[MPlayer-cvslog] r33613 - in trunk/gui: mplayer/mw.c wm/wskeys.h

[Reimar Döffinger]

On 15 Jun 2011, at 11:19, Ingo Brückl <ib at wupperonline.de> wrote:
> Diego Biurrun wrote on Wed, 15 Jun 2011 01:37:45 +0200:
> 
>> On Tue, Jun 14, 2011 at 04:48:52PM +0200, ib wrote:
>>> 
>>> --- trunk/gui/wm/wskeys.h     Tue Jun 14 16:39:26 2011        (r33612)
>>> +++ trunk/gui/wm/wskeys.h     Tue Jun 14 16:48:52 2011        (r33613)
>>> @@ -30,6 +30,7 @@
>>> #define wsXF86RaiseVolume 0x13 + 256
>>> #define wsXF86Mute        0x12 + 256
>>> #define wsXF86Play        0x14 + 256
>>> +#define wsXF86Pause       0x31 + 256
>>> #define wsXF86Stop        0x15 + 256
>>> #define wsXF86Prev        0x16 + 256
>>> #define wsXF86Next        0x17 + 256
> 
>> This header duplicates libvo/wskeys.h - why?
> 
> It doesn't. It did duplicate libvo/wskeys.h, but now only contains additional
> multimedia key definitions. If they can go into libvo/wskeys.h, just tell me.

I don't think anything speaks against having them all in a single file.
>