[MPlayer-cvslog] r32777 - in trunk: DOCS/man/en/mplayer.1 help/help_mp-cs.h help/help_mp-de.h help/help_mp-en.h help/help_mp-es.h help/help_mp-fr.h help/help_mp-hu.h help/help_mp-it.h help/help_mp-pl.h help/help_mp...

[Clément Bœsch]

On Thu, Jan 13, 2011 at 07:50:52AM +0100, Reimar Döffinger wrote:
> On Wed, Jan 12, 2011 at 10:08:12PM +0100, Clément Bœsch wrote:
> > On Mon, Jan 10, 2011 at 08:29:51PM +0100, Reimar Döffinger wrote:
> > > On Mon, Jan 10, 2011 at 08:18:52PM +0100, cboesch wrote:
> > > > +     end_at.type == END_AT_SIZE && end_at.pos < stream_tell(mpctx->stream))
> > > 
> > > I just realized one thing: I think this might not behave quite as expected
> > > when used with -sb
> > > Well, or rather I can't decide which would be the expected behaviour.
> > > Maybe you could test it (for both if conditions) and document it?
> > 
> > What do you want to say more than "Stop at given time or byte position."?
> 
> The only question is "relative to the start of the file or relative to
> the playback start (as given with -sb or -ss respectively)"?
> 

Patch attached. But you were right, in that state the option is not really
consistent. Sorry it took months for the patch…

Also, my English is a bit approximative as usual, so feel free to propose
a better wording.

> > Also, I'm not able to get -sb working correctly :p
> 
> I think it only works with (some?) MPEG formats.
> 

Indeed.

> > Btw, -sb seems to be used only to jump a few bytes (no MB for example) so
> > not sure this is really relevant.
> 
> Huh? It should be possible to use -sb to skip e.g. the first GB.
> 

-sb does not seem to take any 'b', 'kb', 'gb' units, that's why I said
that.

> > And finally, -endpos with byte position "may not be accurate" from manpage
> > so…
> 
> Well, being off a full GB is more than just "not accurate".
> 

Agree :)

-- 
Clément B.
-------------- next part --------------
Index: DOCS/man/en/mplayer.1
===================================================================
--- DOCS/man/en/mplayer.1	(revision 33579)
+++ DOCS/man/en/mplayer.1	(working copy)
@@ -1665,7 +1665,7 @@
 .I NOTE:
 Byte position may not be accurate, as it can only stop at a frame boundary.
 When used in conjunction with \-ss option, \-endpos time will shift forward by
-seconds specified with \-ss.
+seconds specified with \-ss if not a byte position.
 .sp 1
 .I EXAMPLE:
 .PD 0
@@ -1677,7 +1677,8 @@
 .IPs "\-ss 10 \-endpos 56"
 Stop at 1 minute 6 seconds.
 .IPs "\-endpos 100mb"
-Encode only 100 MB.
+Encode 100 MB if mencoder, or stop when reaching "position 100MB" of the input
+file if mplayer.
 .RE
 .PD 1
 .
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20110611/43cfc84f/attachment.asc>