[MPlayer-cvslog] r33888 - in trunk: Makefile gui/win32/playlist.c gui/win32/playlist.h

[Reimar Döffinger]

On 26 Jul 2011, at 23:28, Diego Biurrun <diego at biurrun.de> wrote:

> On Fri, Jul 22, 2011 at 12:41:11AM +0200, Diego Biurrun wrote:
>> On Fri, Jul 22, 2011 at 12:24:57AM +0200, diego wrote:
>>> 
>>> --- trunk/gui/win32/playlist.c    Thu Jul 21 03:21:36 2011    (r33887)
>>> +++ trunk/gui/win32/playlist.c    Fri Jul 22 00:24:57 2011    (r33888)
>>> @@ -22,6 +22,7 @@
>>> 
>>> #include <windows.h>
>>> +#include <stdbool.h>
>>> #include <stdio.h>
>>> @@ -29,7 +30,7 @@
>>> 
>>> -BOOL adddirtoplaylist(playlist_t *playlist, const char *path, BOOL recursive)
>>> +bool adddirtoplaylist(playlist_t *playlist, const char *path, bool recursive)
>>> {
>>>     HANDLE findHandle = INVALID_HANDLE_VALUE;
>>> --- trunk/gui/win32/playlist.h    Thu Jul 21 03:21:36 2011    (r33887)
>>> +++ trunk/gui/win32/playlist.h    Fri Jul 22 00:24:57 2011    (r33888)
>>> @@ -24,7 +24,7 @@
>>> 
>>> -#include <windows.h>
>>> +#include <stdbool.h>
>>> 
>>> @@ -56,6 +56,6 @@ struct playlist_t
>>> 
>>> playlist_t *create_playlist(void);
>>> -BOOL adddirtoplaylist(playlist_t *playlist, const char* path, BOOL recursive);
>>> +bool adddirtoplaylist(playlist_t *playlist, const char* path, bool recursive);
>> 
>> Ingo, can you confirm this is OK or not?
> 
> I just confirmed this works fine on Cygwin, so I guess we can keep it.

Well, bool has different semantic and also performance.
Using int would be more similar in behaviour to BOOL and consistent with basically all other parts of MPlayer.