[MPlayer-cvslog] r33911 - trunk/stream/cache2.c

[Diego Biurrun]

On Mon, Jul 25, 2011 at 08:48:02PM +0200, Reimar Döffinger wrote:
> On Mon, Jul 25, 2011 at 08:45:46PM +0200, Nicolas George wrote:
> > Le septidi 7 thermidor, an CCXIX, Reimar Döffinger a écrit :
> > > > +    struct sigaction sa = { { 0 } };
> > > This is wrong, POSIX does not require it to start with or even contain
> > > a struct or union.
> > > Thus your code potentially will not compile on some systems.
> > > If you want to get rid of the warning you'll have to use memset.
> > 
> > What about this:
> > 
> > struct sigaction sa = { .sa_flags = 0 };
> > 
> > ? sa_flags is required to be present and an int.
> 
> Well, then you could instead just merge the immediately
> following sa_handler assignment in it.

I have that as a local commit - will push later.

Diego