[MPlayer-cvslog] r32780 - in trunk: libao2/ao_dxr2.c libvo/vo_dxr2.c

[Diego Biurrun]

On Wed, Jan 12, 2011 at 11:30:46AM +0100, Tobias Diedrich wrote:
> Diego Biurrun wrote:
> > On Tue, Jan 11, 2011 at 01:10:00AM +0100, ranma wrote:
> > > 
> > > Log:
> > > Fix compiler warnings in ao_dxr2.c and vo_dxr2.c
> > 
> > Which ones?  Please add the warnings to the log message.
> 
> Duplicate prototype (ao_dxr2), missing prototypes and unused
> variable (vo_dxr2) IIRC.

You should paste the warnings into the log message.

> > > --- trunk/libao2/ao_dxr2.c	Tue Jan 11 01:07:52 2011	(r32779)
> > > +++ trunk/libao2/ao_dxr2.c	Tue Jan 11 01:09:59 2011	(r32780)
> > > @@ -175,9 +175,11 @@ static int get_space(void){
> > >  
> > > +/* write_dxr2 from libvo/dxr2.c */
> > > +extern int write_dxr2(const unsigned char *data, int len);
> > > +
> > >  static void dxr2_send_lpcm_packet(unsigned char* data,int len,int id,unsigned int timestamp,int freq_id)
> > >  {
> > > -  int write_dxr2(const unsigned char *data, int len);
> > 
> > What warning does this fix?
> 
> Duplicate prototype.
> 
> > In any case this forward declaration should be replaced by a header.
> 
> I wanted to keep the changes minimal, I'm not sure it's worth
> spending more time cleaning up this part of the code.
> After all it was broken for about 6 Months and no one noticed.
> I myself no longer have the hardware to test.
> At least now it compiles again and doesn't give compiler warnings.

I valiantly fought to move all extern and forward declarations into
proper header files and would hate to see the effort subverted.

> > > +void dxr2_send_sub_packet(unsigned char* data,int len,int id,unsigned int timestamp);
> > 
> > This is wrong, the function should be made static instead.
> 
> Hmm, I didn't look into other code to see if it is used anywhere.

It is not, see grep.

Diego