[MPlayer-cvslog] r32731 - in trunk: path.c path.h

[Clément Bœsch]

On Thu, Dec 30, 2010 at 01:23:41PM +0100, Reimar Döffinger wrote:
> On Tue, Dec 28, 2010 at 10:19:38PM +0100, Clément Bœsch wrote:
> > What do you think of this patch? Also, I'm not sure it solve the
> > "security" issue mentionned by Reimar since I didn't figure out a real
> > case example.
> 
> It should probably not make a difference for this use case.
> 
> >  /**
> > - * @brief Indicates weither the path is absolute or not.
> > + * @brief Join two paths if new path is not absolute.
> 
> Huh? What does "new path" mean here?
> 

Oups. It was for when the variable was called "new_path"; it's of course
the path argument. I fixed it.

> > + * @param base File or directory base path.
> > + * @param path Path to concatenate with the base.
> > + * @return New allocated string with the path, or NULL in case of error.
> > + * @warning Do not forget the trailing path separator at the end of the base
> > + *          path if it is a directory: since file paths are also supported,
> > + *          this separator will make the distinction.
> 
> Add a note that the resulting path will still depend on the current dir
> for Windows paths of the form
> x:something
> /something
> \something

Applied with this change.

[...]

-- 
Clément B.
Not sent from a jesusPhone.