[MPlayer-cvslog] r32724 - trunk/configure

[Diego Biurrun]

On Wed, Dec 29, 2010 at 03:47:58PM +0100, Reimar Döffinger wrote:
> On 28 dec 2010, at 12:33, Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Sun, Dec 19, 2010 at 11:02:53PM +0100, reimar wrote:
> >> 
> >> Log:
> >> Compilation fixes for currentl Cygwin.
> >> 
> >> --- trunk/configure    Sun Dec 19 15:19:04 2010    (r32723)
> >> +++ trunk/configure    Sun Dec 19 23:02:52 2010    (r32724)
> >> @@ -1519,6 +1519,12 @@ if win32 ; then
> >> 
> >> +if cygwin ; then
> >> +  # e.g. priority.c needs _WIN32 define, but
> >> +  # latest cygwin no longer defines it
> >> +  extra_cflags="-D_WIN32 $extra_cflags"
> >> +fi
> > 
> > I just talked about this with Jean-Baptiste Kempf on IRC and it looks
> > quite suspicious.
> > 
> > Cygwin should define _WIN32, why isn't it doing it?  See the discussion
> > of the patch I posted to dvdnav-discuss and the MSDN entry:
>
> What makes you think it should? Cygwin is _not_ intended for compiling
> WIN32 (in terms of API) but POSIX.

I'm getting more confused by the minute, likely due to my ignorance of
all things Windows.  Why are you #defining _WIN32 for Cygwin then?

It seems to that replacing checks for _WIN32 with checks for both
__MINGW32__ and __CYGWIN__ is the correct fix.

Diego