[MPlayer-cvslog] r32931 - in trunk/gui/skin: skin.c skin.h

[Ingo Brückl]

Diego Biurrun wrote on Sun, 27 Feb 2011 10:00:03 +0100:

> On Sat, Feb 19, 2011 at 02:23:16PM +0100, ib wrote:
>>
>> Log:
>> Remove unused function.

> Which unused function?

Hmm... would it be more descriptive to say "Remove unused function
trimleft()"?

And what should be a verbose description? "The function has been removed
since it isn't used anywhere"?

I really mean this genuinely and don't intend to offence.

Oughtn't a log message be read together with the patch? I doubt that log
messages are too useful without seeing the patch, but I agree that a good
message makes a complicated patch easier to understand. But if the patch is
trivial has there to be a very descriptive message?

> Do you happen to use the -m flag instead of writing them in an editor?

No, that's not the reason.

> Take your time to write log messages,

I promise to try to improve.

Ingo