[MPlayer-cvslog] r32918 - trunk/gui/skin/font.c

[Nicolas George]

Le nonidi 29 pluviôse, an CCXIX, ib a écrit :
> + unsigned char *p, uchar[4] = {'\0'};

Why not just uchar[4] = ""?

Although, this part of the code seems wrong:

	p = *str;
	*str = g_utf8_next_char( *str );
	strncpy( uchar, p, *str - p );

A Unicode codepoint can take up to 6 octets in UTF-8. And uchar seems to be
later used as a string, that means an additional terminating 0.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20110217/b3f19d7d/attachment.pgp>