[MPlayer-cvslog] r32857 - trunk/mplayer.c

[Reimar Döffinger]

On Sat, Feb 05, 2011 at 09:03:25PM +0100, Clément Bœsch wrote:
> On Sat, Feb 05, 2011 at 08:57:58PM +0100, Reimar Döffinger wrote:
> > On Sat, Feb 05, 2011 at 08:05:02PM +0100, cboesch wrote:
> > > Author: cboesch
> > > Date: Sat Feb  5 20:05:02 2011
> > > New Revision: 32857
> > > 
> > > Log:
> > > FPS are in float in sh_video, not double.
> > > 
> > > Original patch by rodries/wiimc.org. This is necessary for the next fix to come.
> > 
> > No it is completely irrelevant.
> > 
> > > Modified:
> > >    trunk/mplayer.c
> > > 
> > > Modified: trunk/mplayer.c
> > > ==============================================================================
> > > --- trunk/mplayer.c	Sat Feb  5 15:04:07 2011	(r32856)
> > > +++ trunk/mplayer.c	Sat Feb  5 20:05:02 2011	(r32857)
> > > @@ -3499,7 +3499,7 @@ if(1 || mpctx->sh_video) {
> > >  // after reading video params we should load subtitles because
> > >  // we know fps so now we can adjust subtitle time to ~6 seconds AST
> > >  // check .sub
> > > -  double fps = mpctx->sh_video ? mpctx->sh_video->fps : 25;
> > > +  float fps = mpctx->sh_video ? mpctx->sh_video->fps : 25;
> > 
> > Please revert this, fps should be double everywhere, just
> > because some places are incorrectly float is not a reason
> > to undo the work already made!
> > float is not acceptable because it cannot represent
> > e.g. 30000/1001 accurately enough for some purposes.
> 
> Ok, I'm sorry, I'll revert it in a minute. I thought since it was float in
> this main "big" structure to be reliable. Sorry again.

I know it's a confusing mess. And I also wasn't really aware
it is still float there and not double.
I think it should be fine for you to change all fps stuff to double
whenever you encounter it.
It might cause a few bugs but it's probably still better
than dragging it out forever.