[MPlayer-cvslog] r34428 - trunk/mplayer.c

[Diego Biurrun]

On Sun, Dec 11, 2011 at 08:02:01PM -0500, compn wrote:
> On Mon, 12 Dec 2011 00:39:45 +0100, Diego Biurrun wrote:
> >We simply should not keep perpetuating this bad habit into the future,
> >but drop it instead.  No readability is gained by splitting off one-line
> >indentation changes into separate commits; it just wastes time.
> >
> >>   As I understand it our coding policy says, to not include large indentations
> >> in a non-cosmetic commit. But it doesn't say you must include small cosmetics.
> >
> >It also does not say "use your common sense" because that is kind of a given.
> 
> it says no mixing cosmetics and functional changes.
> 
> submit a patch to svn-howto if you want...

I don't think this requires clarification, but I just sent a patch.

Diego