[MPlayer-cvslog] r34428 - trunk/mplayer.c

[Alexander Strasser]

Diego Biurrun wrote:
> On Sun, Dec 11, 2011 at 03:44:36PM +0100, ib wrote:
> > 
> > Log:
> > Cosmetic: Adjust indent.
> > 
> > --- trunk/mplayer.c	Sun Dec 11 15:43:16 2011	(r34427)
> > +++ trunk/mplayer.c	Sun Dec 11 15:44:36 2011	(r34428)
> > @@ -3061,7 +3061,7 @@ play_next_file:
> >                  if (cmd->id == MP_CMD_GUI)
> >                      gui(GUI_RUN_MESSAGE, cmd->args[0].v.s);
> >                  else
> > -                gui(GUI_RUN_COMMAND, (void *)cmd->id);
> > +                    gui(GUI_RUN_COMMAND, (void *)cmd->id);
> >                  mp_cmd_free(cmd);
> 
> This is completely silly.  Fold such things into the original commit.

  Calling it "completely silly" sounds exaggerated to me.

  I don't have a problem with this commit and I do not think many developers
have. Of course it might be convenient to not split this for the committer
if he likes it that way.

  As I understand it our coding policy says, to not include large indentations
in a non-cosmetic commit. But it doesn't say you must include small cosmetics.

  Alexander