[MPlayer-cvslog] r33888 - in trunk: Makefile gui/win32/playlist.c gui/win32/playlist.h

[Reimar Döffinger]

On 4 Aug 2011, at 12:10, Ingo Brückl <ib at wupperonline.de> wrote:
> Reimar Döffinger wrote on Tue, 2 Aug 2011 21:30:17 +0200:
> 
>> On Mon, Aug 01, 2011 at 03:26:03PM +0200, Ingo Brückl wrote:
>>> Performance shouldn't be an issue with the GUI, but I don't
>>> know what you mean by "different semantic" or "special behaviour".
> 
>> E.g.
>> BOOL a = 2;
>> printf("%i", a);
>> prints: 2
> 
>> bool a = 2;
>> printf("%i", a);
>> prints: 1
> 
> Oh, now I understand what you meant, bool isn't just a typedef int.
> 
> I agree with Diego that Windows BOOL wasn't the right type to use, because
> there is no Windows context with this variable, but as I mentioned, I'd
> prefer boolean type variables over int when they have a strict yes/no
> meaning. Although I don't mind using int that much, I'm curious wether you
> are ok with stdbool.h in general?

Well, it means you'll have to change the whole API if you ever want to pass error values back and as said it has disadvantages of being less consistent with the rest of MPlayer and probably a lot of developers who aren't really familiar with the semantics.
But no, I have nothing against it, particularly in the GUI, if you think it preferable overall still.

Reimar

>