[MPlayer-cvslog] r33218 - trunk/gui/util/bitmap.c

Ingo Brückl ib at wupperonline.de
Tue Apr 5 11:52:45 CEST 2011


I wrote on Tue,  5 Apr 2011 11:28:59 +0200 (CEST):

> rephrase #if condition positively.

> -#if !HAVE_BIGENDIAN
> -        bf->Image[i + 3] = 0;
> -#else
> +    for (i = 0; i < bf->ImageSize; i += 4)
> +#if HAVE_BIGENDIAN
>          bf->Image[i] = 0;
> +#else
> +        bf->Image[i + 3] = 0;
>  #endif
>  }

Isn't that needless? The PNG specification says that all integers that
require more than one byte shall be in network byte order which is big-endian
AFAIK.

Ingo


More information about the MPlayer-cvslog mailing list