[MPlayer-cvslog] r33214 - trunk/gui/util/bitmap.c

[Ingo Brückl]

Reimar Döffinger wrote on Mon, 4 Apr 2011 20:46:05 +0200:

> On Mon, Apr 04, 2011 at 08:35:25PM +0200, ib wrote:
>> Author: ib
>> Date: Mon Apr  4 20:35:25 2011
>> New Revision: 33214
>>
>> Log:
>> Don't change original image during conversion.
>>
>> Modified:
>>    trunk/gui/util/bitmap.c
>>
>> Modified: trunk/gui/util/bitmap.c
>> ========================================================================= =====
>> --- trunk/gui/util/bitmap.c   Mon Apr  4 20:25:11 2011        (r33213)
>> +++ trunk/gui/util/bitmap.c   Mon Apr  4 20:35:25 2011        (r33214)
>> @@ -242,10 +242,8 @@ int Convert32to1(txSample *in, txSample
>>
>>          if (buf[i] != transparent)
>>              tmp |= 0x80;
>> -        else {
>> -            buf[i] = 0;
>> +        else

> I think that very much is intentional, if you run it on a system
> where the XShape extension is not supported it will make the transparent
> parts at least only black, if you remove it it will be some really
> horrible pink colour or something like that.

Yes, I noticed and reverted it only minutes after the commit.

Ingo